-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SiLabs firmware probing helper from ZHA into homeassistant_hardware
#131586
base: dev
Are you sure you want to change the base?
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @dmulcahey, @Adminiuga, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
homeassistant_hardware
CI failures are unrelated: ERROR tests/components/cloud/test_client.py::test_async_create_repair_issue_known[reset_bad_custom_domain_configuration] - Failed: Translation not found for cloud: `issues.reset_bad_custom_domain_configuration.title`. Please add to homeassistant/components/cloud/strings.json
ERROR tests/components/cloud/test_client.py::test_async_create_repair_issue_known[warn_bad_custom_domain_configuration] - Failed: Translation not found for cloud: `issues.warn_bad_custom_domain_configuration.title`. Please add to homeassistant/components/cloud/strings.json
ERROR tests/components/cloud/test_repairs.py::test_create_repair_issues_at_startup_if_logged_in - Failed: Translation not found for cloud: `issues.legacy_subscription.title`. Please add to homeassistant/components/cloud/strings.json
ERROR tests/components/cloud/test_repairs.py::test_legacy_subscription_delete_issue_if_no_longer_legacy - Failed: Translation not found for cloud: `issues.legacy_subscription.title`. Please add to homeassistant/components/cloud/strings.json
ERROR tests/components/cloud/test_repairs.py::test_legacy_subscription_repair_flow - Failed: Translation not found for cloud: `issues.legacy_subscription.title`. Please add to homeassistant/components/cloud/strings.json
ERROR tests/components/cloud/test_repairs.py::test_legacy_subscription_repair_flow_timeout - Failed: Translation not found for cloud: `issues.legacy_subscription.fix_flow.abort.operation_took_too_long`. Please add to homeassistant/components/cloud/strings.json |
Proposed change
Currently, ZHA provides a way to probe SiLabs firmware via a helper in a repair. The
homeassistant_hardware
firmware config flow actually uses this helper function to determine running firmware. This is a bit backwards, as thehomeassistant_hardware
integration should be providing this, not the other way around.To isolate the
universal-silabs-flasher
dependency to justhomeassistant_hardware
, I've provided a "proxy" enum forApplicationType
. This allows all integrations requiring firmware info to directly import fromhomeassistant_hardware
instead of the external package.This is the first of many PRs to clean up the various integrations interacting with Zigbee/Thread firmwares.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: