Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SiLabs firmware probing helper from ZHA into homeassistant_hardware #131586

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Nov 25, 2024

Proposed change

Currently, ZHA provides a way to probe SiLabs firmware via a helper in a repair. The homeassistant_hardware firmware config flow actually uses this helper function to determine running firmware. This is a bit backwards, as the homeassistant_hardware integration should be providing this, not the other way around.

To isolate the universal-silabs-flasher dependency to just homeassistant_hardware, I've provided a "proxy" enum for ApplicationType. This allows all integrations requiring firmware info to directly import from homeassistant_hardware instead of the external package.

This is the first of many PRs to clean up the various integrations interacting with Zigbee/Thread firmwares.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant_hardware) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant_hardware can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant_hardware Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant_yellow) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant_yellow can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant_yellow Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant_sky_connect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant_sky_connect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant_sky_connect Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@puddly puddly changed the title Move SiLabs firmware probing helper out of ZHA Move SiLabs firmware probing helper from ZHA into homeassistant_hardware Nov 25, 2024
@puddly
Copy link
Contributor Author

puddly commented Nov 25, 2024

CI failures are unrelated:

ERROR tests/components/cloud/test_client.py::test_async_create_repair_issue_known[reset_bad_custom_domain_configuration] - Failed: Translation not found for cloud: `issues.reset_bad_custom_domain_configuration.title`. Please add to homeassistant/components/cloud/strings.json
ERROR tests/components/cloud/test_client.py::test_async_create_repair_issue_known[warn_bad_custom_domain_configuration] - Failed: Translation not found for cloud: `issues.warn_bad_custom_domain_configuration.title`. Please add to homeassistant/components/cloud/strings.json
ERROR tests/components/cloud/test_repairs.py::test_create_repair_issues_at_startup_if_logged_in - Failed: Translation not found for cloud: `issues.legacy_subscription.title`. Please add to homeassistant/components/cloud/strings.json
ERROR tests/components/cloud/test_repairs.py::test_legacy_subscription_delete_issue_if_no_longer_legacy - Failed: Translation not found for cloud: `issues.legacy_subscription.title`. Please add to homeassistant/components/cloud/strings.json
ERROR tests/components/cloud/test_repairs.py::test_legacy_subscription_repair_flow - Failed: Translation not found for cloud: `issues.legacy_subscription.title`. Please add to homeassistant/components/cloud/strings.json
ERROR tests/components/cloud/test_repairs.py::test_legacy_subscription_repair_flow_timeout - Failed: Translation not found for cloud: `issues.legacy_subscription.fix_flow.abort.operation_took_too_long`. Please add to homeassistant/components/cloud/strings.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants