Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reolink bitrate and framerate select entities #131571

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Nov 25, 2024

Breaking change

Proposed change

Add Reolink bitrate and framerate select entities for both the low resultion fluent and high resolution clear streams

Needs this version bump: #131568

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@starkillerOG starkillerOG marked this pull request as ready for review November 26, 2024 06:15
@frenck frenck added this to the 2024.12.0b0 milestone Nov 26, 2024
@frenck frenck marked this pull request as draft November 26, 2024 07:44
@starkillerOG starkillerOG marked this pull request as ready for review November 26, 2024 08:11
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants