-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stookwijzer api to atlas leefomgeving and add extra sensors #104846
Update stookwijzer api to atlas leefomgeving and add extra sensors #104846
Conversation
Co-authored-by: Joost Lekkerkerker <[email protected]>
Co-authored-by: Joost Lekkerkerker <[email protected]>
Co-authored-by: Joost Lekkerkerker <[email protected]>
@joostlek Does this PR look familiar to you? Would you mind reviewing this one as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this PR does look familiar, but in its current form it's doing way too much. Can you split out stuff like the dependency bump, coordinator, new sensors?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Splitting will be a problem. Because of the dependency so many had to change. And I even added a lot of new tests. We can probably take more time for this review and keep it as is? |
Yes but a dependency change does not have to change the way we fetch data or the amount of sensors. Like if it was only 1 new entity, sure. But in this case this PR does too much |
@joostlek Honestly, that review is kinda waste of time. You've seen a few pushes from me + it is draft for a reason. Most of the code will look different. |
I think this is rather complete now. Now I've mostly refactored it, I do agree with the other comments that this needs to be split out into multiple PRs. So, what we first can do here, is make a PR that bump the dependency in the existing integrations and does the bare minimum to get there. That would mean a PR with a Dependency bump, config entry migration + issue, config flow adjustments, config flow test adjustments, and probably the init tests (which test the migration of the entry + issue raised in case of failure) + diagnostics adjustments. As follow-up PRs could be:
With this PR in place, that shouldn't be too much of a task to split out. After that, I think there are quite a few improvements that can be made upstream in the client library as well. Mostly in terms of error handling. Right now, it just silences all the errors and returns ../Frenck |
Extracted part 1, the bump: #131567 |
Coordinator added in #131574 |
Entity descriptions support: #131585 |
New sensors: #131587 |
Extend tests for Stookwijzer init: #131589 |
Enable strict typing for Stookwijzer: #131590 |
Add data description for Stookwijzer config flow: #131591 |
And the last one: Record current IQS state for Stookwijzer: #131592 |
Closing this PR, as everything in here is done in the splitter-out PRs listed above. ../Frenck |
Breaking change
Stookwijzer states are updated. New possible states are: code_yellow, code_orange and code_red.
Proposed change
The API has changed, also the different advices are added (source https://iplo.nl/thema/lucht/houtstook-de-stookwijzer-en-het-stookalert/)
fwestenberg/stookwijzer@v1.3.0...v1.4.10
To fix the issue mentioned in #104705, the
pyreproj
dependency is removed.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: