Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Add support for extra index url to the pip installer #101050

Closed
wants to merge 1 commit into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 28, 2023

Proposed change

needs home-assistant/docker#297

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck
Copy link
Member

frenck commented Sep 30, 2023

I think if we rework the base image with the new index (by delivering a default pip configuration) most of this code (and the old code) can actually be removed.

@bdraco
Copy link
Member Author

bdraco commented Oct 1, 2023

I think we still need to set something in the base image or add detection for alpine/musl to set the index url

@bdraco
Copy link
Member Author

bdraco commented Oct 2, 2023

I guess we have the util to check if it's an official image already so we could tie it to that instead

@frenck
Copy link
Member

frenck commented Oct 6, 2023

Going to close this PR for now. It will end up being a different PR all together once our base images have been adjusted (removing most logic, instead of adding new things).

(Also, I'm cleaning up the PRs a bit 🧹 )

../Frenck

@frenck frenck closed this Oct 6, 2023
@frenck frenck deleted the extra_index_url branch October 6, 2023 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants