Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

letsencrypt: Bump certbot-dns-directadmin to 1.0.12 #3828

Merged
merged 1 commit into from
Nov 25, 2024
Merged

letsencrypt: Bump certbot-dns-directadmin to 1.0.12 #3828

merged 1 commit into from
Nov 25, 2024

Conversation

0xFelix
Copy link
Contributor

@0xFelix 0xFelix commented Nov 17, 2024 •
edited by coderabbitai bot
Loading

Bump certbot-dns-directadmin to 1.0.12 in hope to fix issues with the support for pointer domains that was introduced in version 1.0.4.

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Updated the certbot-dns-directadmin package to version 1.0.12 for improved DNS support.

  • Documentation

    • Changelog updated to include new version entry for 5.2.5 with detailed changes.

  • Chores

    • Incremented version number in configuration files to reflect the latest updates.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 17, 2024 •
edited
Loading

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes in this pull request include updates to the Let's Encrypt project, specifically the addition of a new version entry in the changelog for version 5.2.5, which notes the update of the certbot-dns-directadmin package to version 1.0.12. Additionally, the build.yaml file has been modified to reflect this new version for the CERTBOT_DNS_DIRECTADMIN_VERSION argument. The config.yaml file has also been updated to change its version from 5.2.4 to 5.2.5, maintaining the overall structure and content of the configuration.

Changes

File Change Summary
letsencrypt/CHANGELOG.md Added version entry ## 5.2.5 and noted update to certbot-dns-directadmin version 1.0.12.
letsencrypt/build.yaml Updated CERTBOT_DNS_DIRECTADMIN_VERSION from 1.0.4 to 1.0.12.
letsencrypt/config.yaml Updated version from 5.2.4 to 5.2.5.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 459b352 and 212e248.

📒 Files selected for processing (3)
  • letsencrypt/CHANGELOG.md (1 hunks)
  • letsencrypt/build.yaml (1 hunks)
  • letsencrypt/config.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • letsencrypt/CHANGELOG.md
  • letsencrypt/build.yaml
  • letsencrypt/config.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

frenck
frenck requested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @0xFelix 👋

It looks like the CI is failing. Can you take a look?

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 18, 2024 13:14
@0xFelix
Copy link
Contributor Author

0xFelix commented Nov 18, 2024

Hi @frenck 👋

I'm looking at what I can do.

We're being blocked by cybercinch/certbot-dns-directadmin#30 and cybercinch/certbot-dns-directadmin#32.

sairon
sairon reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@sairon sairon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's 1.0.10 on PyPI now, I'll leave it up to you if you'll prefer to update this PR or start with a new one

@0xFelix 0xFelix changed the title letsencrypt: Bump certbot-dns-directadmin to 1.0.6 letsencrypt: Bump certbot-dns-directadmin to 1.0.10 Nov 23, 2024
@0xFelix 0xFelix marked this pull request as ready for review November 23, 2024 14:47
@home-assistant home-assistant bot requested a review from frenck November 23, 2024 14:47
@0xFelix
Copy link
Contributor Author

0xFelix commented Nov 23, 2024

@frenck @sairon Done, changed the version to 1.0.10.

@0xFelix
Copy link
Contributor Author

0xFelix commented Nov 23, 2024 •
edited
Loading

CI is failing again. certbot = "^3.0.1" is too new.

See cybercinch/certbot-dns-directadmin#32 (comment)

@guisea
Copy link

guisea commented Nov 24, 2024

CI is failing again. certbot = "^3.0.1" is too new.

See cybercinch/certbot-dns-directadmin#32 (comment)

Hey @0xFelix, please note new package is uploaded. I have loosened the version required as suggested. New version is 1.0.12.

Cheers

@0xFelix 0xFelix changed the title letsencrypt: Bump certbot-dns-directadmin to 1.0.10 letsencrypt: Bump certbot-dns-directadmin to 1.0.12 Nov 25, 2024
@0xFelix
Copy link
Contributor Author

0xFelix commented Nov 25, 2024

@guisea Thank you again, very much appreciated.

agners
agners approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Rebased on master which required the bump to 5.2.5.

sairon
sairon approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@sairon sairon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks everyone!

@sairon sairon merged commit 3bd532f into home-assistant:master Nov 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sairon sairon sairon approved these changes

@agners agners agners approved these changes

@frenck frenck Awaiting requested review from frenck

Assignees
No one assigned
Labels
add-on: letsencrypt cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xFelix @guisea @agners @frenck @sairon