Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake #2

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Add flake #2

merged 3 commits into from
Feb 8, 2024

Conversation

TornaxO7
Copy link
Contributor

Makes it friendler for nix users :)

@holly-hacker
Copy link
Owner

Hi, thanks for the PR! I haven't used flakes that much myself, so I left some questions and review comments.

I'd like to mention that while td will have automatic database upgrading if I get back into developing it, I didn't intend on people following the main branch so if I pick up development again, I may move it to a develop branch as to not introduce breaking changes to main.

result Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
.github/workflows/update-nix-flake.yaml Outdated Show resolved Hide resolved
@holly-hacker
Copy link
Owner

@TornaxO7 I just noticed that GitHub never saved my feedback, they should be there now. Could you process this feedback?

@TornaxO7
Copy link
Contributor Author

TornaxO7 commented Feb 8, 2024

Changes applied

@holly-hacker
Copy link
Owner

Looks good, thanks a lot!

@holly-hacker holly-hacker merged commit 056fefd into holly-hacker:main Feb 8, 2024
1 check passed
@TornaxO7 TornaxO7 deleted the add-flake branch February 8, 2024 21:48
@TornaxO7
Copy link
Contributor Author

TornaxO7 commented Feb 8, 2024

Looks good, thanks a lot!

No problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants