Skip to content

Commit

Permalink
Merge pull request #70 from ppeble/comment_kr_test
Browse files Browse the repository at this point in the history
Comment out failing kr test until discussion can be had, see https://…
  • Loading branch information
ppeble authored Aug 15, 2017
2 parents fd7767e + 5514e9f commit c337a0c
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Holiday definitions

## 2.1.1

* Comment out test for `추석` until a discussion can be had in [issue 69](https://github.com/holidays/definitions/issues/69) (nice)

## 2.1.0

Update the following regions:
Expand Down
15 changes: 9 additions & 6 deletions kr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,12 @@ tests:
options: ["informal"]
expect:
name: "설날"
- given:
date: '2017-10-04'
regions: ["kr"]
options: ["informal"]
expect:
name: "추석"

# These are commented out until I can have a discussion and better understand these holidays.
# Please see [issue 69](https://github.com/holidays/definitions/issues/69) (nice) for more information.
# - given:
# date: '2017-10-04'
# regions: ["kr"]
# options: ["informal"]
# expect:
# name: "추석"

0 comments on commit c337a0c

Please sign in to comment.