fixed file-sharing for electron > 31 #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafapaezbas
force-pushed
the
fix-electron-33-file-sharing
branch
from
f21ec80 to
d3456ce
Compare
rafapaezbas
added a commit
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming release of platform (1.9) includes the upgrade of the electron runtime to version 33. Since version 32, the file objects in the html
inputwith typefiledoes not include the path of the file. So the preload (which has access to the right context to read a file path) exposes the getPathForFile from the webUtils.See: https://www.electronjs.org/blog/electron-32-0 and https://github.com/electron/electron/pull/42053/files