Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor until result #514

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Refactor until result #514

merged 3 commits into from
Dec 31, 2024

Conversation

rafapaezbas
Copy link
Contributor

No description provided.

maidh91
maidh91 approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@maidh91 maidh91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

would be great if we can add some comment, or set const STOP_CHAR = \n`` at the top of the untilResult fn to quickly remind of the ending condition

@rafapaezbas rafapaezbas merged commit 368e567 into main Dec 31, 2024
3 checks passed
@rafapaezbas rafapaezbas deleted the refactor-until-result branch December 31, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maidh91 maidh91 maidh91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafapaezbas @maidh91