Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prebuilds #50

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Update prebuilds #50

merged 7 commits into from
Jan 9, 2025

Conversation

kasperisager
Copy link
Contributor

@kasperisager kasperisager commented Jan 3, 2025

This updates V8 to v13.2 and removes the experimental FFI API in favour of the new typed function API which is ABI versioned.

Comment on lines -78 to -80
js_ffi_create_function
js_ffi_create_function_info
js_ffi_create_type_info
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The experimental FFI API is now removed.

js_remove_teardown_callback
js_remove_wrap
js_request_garbage_collection
js_resolve_deferred
js_run_module
js_run_script
js_send_inspector_request
js_set_arraybuffer_zero_fill_enabled
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an internal function previously used by bare-buffer.

js_create_function
js_create_function_with_ffi
Copy link
Contributor Author

@kasperisager kasperisager Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto on #50 (comment).

@kasperisager kasperisager marked this pull request as ready for review January 9, 2025 10:04
@kasperisager kasperisager merged commit 94091ab into main Jan 9, 2025
13 checks passed
@kasperisager kasperisager deleted the update-prebuilds branch January 9, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant