Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test assertion in org.apache.helix.rest.server.TestPerInstanceAccessor#testGetAllMessages #2667

Closed
hofi1 opened this issue Oct 18, 2023 · 0 comments · Fixed by #2682 · May be fixed by hofi1/helix#5
Closed

Flaky test assertion in org.apache.helix.rest.server.TestPerInstanceAccessor#testGetAllMessages #2667

hofi1 opened this issue Oct 18, 2023 · 0 comments · Fixed by #2682 · May be fixed by hofi1/helix#5
Labels
bug Something isn't working

Comments

@hofi1
Copy link
Contributor

hofi1 commented Oct 18, 2023

Describe the bug

The test assertion in org.apache.helix.rest.server.TestPerInstanceAccessor#testGetAllInstances is flaky.
These tests compare two sets for containing the same elements in the same order – but it is not deterministic in which order the elements are returned from a set – resulting in a flaky test.

To Reproduce

run:

mvn -pl helix-rest edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.helix.rest.server.TestPerInstanceAccessor -DnondexSeed=933178

Expected behavior

Test should not be flaky – it should pass or fail (in the current case it should pass)

Additional context

non
@hofi1 hofi1 added the bug Something isn't working label Oct 18, 2023
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 18, 2023
fix flaky test assertion apache#2667
8567c69 
fix flaky test assertion in org.apache.helix
.rest.server.TestPerInstanceAccessor.testGetAllMessages
@hofi1 hofi1 mentioned this issue Oct 18, 2023
Open
1 task
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 27, 2023
fix flaky test assertion apache#2667
7f2c73c 
fix flaky test assertion in org.apache.helix
.rest.server.TestPerInstanceAccessor.testGetAllMessages
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 27, 2023
fix flaky test assertion apache#2667
e0b1834 
fix flaky test assertion in org.apache.helix
.rest.server.TestPerInstanceAccessor.testGetAllMessages
@hofi1 hofi1 mentioned this issue Oct 27, 2023
Merged
1 task
@zpinto zpinto mentioned this issue Nov 22, 2023
Merged
junkaixue pushed a commit that referenced this issue Feb 27, 2024
@hofi1
fix flaky test assertion #2667 (#2682)
442be11 
fix flaky test assertion in org.apache.helix
.rest.server.TestPerInstanceAccessor.testGetAllMessages

Co-authored-by: simonh5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@hofi1