fix flaky test assertion #2667 (#2682)

fix flaky test assertion in org.apache.helix .rest.server.TestPerInstanceAccessor.testGetAllMessages Co-authored-by: simonh5 <[email protected]>
apache · Feb 27, 2024 · 442be11 · 442be11
1 parent e8490f9
commit 442be11
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/helix-rest/src/test/java/org/apache/helix/rest/server/TestPerInstanceAccessor.java b/helix-rest/src/test/java/org/apache/helix/rest/server/TestPerInstanceAccessor.java
@@ -331,8 +331,11 @@ public void testGetAllInstances() throws IOException {
 
     Set<String> instances = OBJECT_MAPPER.readValue(instancesStr,
         OBJECT_MAPPER.getTypeFactory().constructCollectionType(Set.class, String.class));
-    Assert.assertEquals(instances, _instancesMap.get(CLUSTER_NAME), "Instances from response: "
-        + instances + " vs instances actually: " + _instancesMap.get(CLUSTER_NAME));
+    String errorMessage = "Instances from response: "+ instances + " vs instances actually: "
+        + _instancesMap.get(CLUSTER_NAME);
+    Assert.assertEquals(instances.size(), _instancesMap.get(CLUSTER_NAME).size(), errorMessage);
+    Assert.assertTrue(instances.containsAll(_instancesMap.get(CLUSTER_NAME)), errorMessage);
+    Assert.assertTrue(_instancesMap.get(CLUSTER_NAME).containsAll(instances), errorMessage);
     System.out.println("End test :" + TestHelper.getTestMethodName());
   }