Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky test assertions in org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor#testComputePartitionAssignment #2640

Closed
hofi1 opened this issue Oct 5, 2023 · 0 comments · Fixed by #2663 · May be fixed by hofi1/helix#4
Closed

flaky test assertions in org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor#testComputePartitionAssignment #2640

hofi1 opened this issue Oct 5, 2023 · 0 comments · Fixed by #2663 · May be fixed by hofi1/helix#4
Labels
bug Something isn't working

Comments

@hofi1
Copy link
Contributor

hofi1 commented Oct 5, 2023 •
edited
Loading

Describe the bug

The test org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor#testComputePartitionAssignment is flaky. The JSON strings in the assertion can change and sometime not pass the assertions.
JSON may change the order of the elements in arrays as well as elements on the same level – this leads to the flaky test.

To Reproduce

mvn -pl helix-rest edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor#testComputePartitionAssignment

Expected behavior

Test should not be flaky – it should pass or fail (in the current case it should pass)

Additional context

Change the assertions from JUNIT-Assertions to JSONAssertions.
@hofi1 hofi1 added the bug Something isn't working label Oct 5, 2023
@hofi1 hofi1 mentioned this issue Oct 5, 2023
Open
1 task
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 5, 2023
fix: fix flaky test assertions (apache#2640)
ed8daee 
in test TestResourceAssignmentOptimizerAccessor
#testComputePartitionAssignment
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 5, 2023
Fix flaky test assertions (apache#2640)
489a70a 
in test TestResourceAssignmentOptimizerAccessor
#testComputePartitionAssignment
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 13, 2023
Fix flaky test assertions (apache#2640)
3c5ac77 
in test TestResourceAssignmentOptimizerAccessor
#testComputePartitionAssignment
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 13, 2023
Fix flaky test assertions (apache#2640)
c9cb87b 
in test TestResourceAssignmentOptimizerAccessor
#testComputePartitionAssignment
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 13, 2023
Fix flaky test assertions (apache#2640)
bae9aff 
in test TestResourceAssignmentOptimizerAccessor
#testComputePartitionAssignment
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 13, 2023
Fix flaky test assertions (apache#2640)
915e414 
in test TestResourceAssignmentOptimizerAccessor
#testComputePartitionAssignment
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 13, 2023
Fix flaky test assertions (apache#2640)
6e8eb21 
in test TestResourceAssignmentOptimizerAccessor
#testComputePartitionAssignment
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 13, 2023
Fix flaky test assertions (apache#2640)
eb11210 
in test TestResourceAssignmentOptimizerAccessor
#testComputePartitionAssignment
@hofi1 hofi1 mentioned this issue Oct 17, 2023
Merged
1 task
junkaixue pushed a commit that referenced this issue Feb 27, 2024
@hofi1
Fix flaky test assertions (#2640) (#2663)
448e7a0 
in test TestResourceAssignmentOptimizerAccessor
#testComputePartitionAssignment

Co-authored-by: simonh5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@hofi1