Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor(#2640) #2663

Conversation

hofi1
Copy link
Contributor

@hofi1 hofi1 commented Oct 17, 2023

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Fixes #2640

Description

The problem in this test is, that a json string gets directly asserted. JSON strings are equal, if they have the same content and structure. Not only the elements in the arrays can change, but also the elements in the same object can change location. This is not considered in the assertion and leads to a flaky test.

This problem was found by the NonDex Engine – to reproduce run

mvn -pl helix-rest edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor#testComputePartitionAssignment

Tests

No test have been written – one existing test has been updated.

  • The following is the result of the "mvn test" command on the appropriate module:
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 02:53 min
    [INFO] Finished at: 2023-10-04T18:42:54-05:00

in test TestResourceAssignmentOptimizerAccessor
#testComputePartitionAssignment
@hofi1 hofi1 changed the title Fix flaky test assertions (#2640) Fix flaky test assertions org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor#testComputePartitionAssignment (#2640) Oct 18, 2023
@hofi1 hofi1 changed the title Fix flaky test assertions org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor#testComputePartitionAssignment (#2640) Fix flaky tests org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor#testComputePartitionAssignment (#2640) Oct 18, 2023
@hofi1 hofi1 changed the title Fix flaky tests org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor#testComputePartitionAssignment (#2640) Fix flaky tests org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor(#2640) Oct 18, 2023
@junkaixue junkaixue merged commit 448e7a0 into apache:master Feb 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants