Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky test org.apache.helix.rest.server.TestInstancesAccessor#testGetAllInstances #2644

Closed
hofi1 opened this issue Oct 5, 2023 · 0 comments · Fixed by #2665 · May be fixed by hofi1/helix#2
Closed

flaky test org.apache.helix.rest.server.TestInstancesAccessor#testGetAllInstances #2644

hofi1 opened this issue Oct 5, 2023 · 0 comments · Fixed by #2665 · May be fixed by hofi1/helix#2
Labels
bug Something isn't working

Comments

@hofi1
Copy link
Contributor

hofi1 commented Oct 5, 2023

Describe the bug

The test org.apache.helix.rest.server.TestInstancesAccessor#testGetAllInstances has a flaky assertion.
The test compares two sets for containing the same elements in the same order – but it is not deterministic in which order the elements are returned from a set – resulting in a flaky test.

To Reproduce

It was found using the NonDex engine and can be reproduced using the following command:

mvn -pl helix-rest edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.helix.rest.server.TestInstancesAccessor

Expected behavior

It is expected that the test checks if the collections contain the same elements in any order and not in a specific order.

Additional context

non
@hofi1 hofi1 added the bug Something isn't working label Oct 5, 2023
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 5, 2023
fix: fix flaky test assertion apache#2644
43ea8ac 
in org.apache.helix.rest.server.
TestInstancesAccessor#testGetAllInstances
@hofi1 hofi1 mentioned this issue Oct 5, 2023
Open
1 task
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 5, 2023
Fix flaky test assertion apache#2644
0c98411 
in org.apache.helix.rest.server.
TestInstancesAccessor#testGetAllInstances
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 13, 2023
Fix flaky test assertion apache#2644
92638af 
in org.apache.helix.rest.server.
TestInstancesAccessor#testGetAllInstances
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 13, 2023
Fix flaky test assertion apache#2644
da3c274 
in org.apache.helix.rest.server.
TestInstancesAccessor#testGetAllInstances
@hofi1 hofi1 mentioned this issue Oct 17, 2023
Merged
1 task
junkaixue pushed a commit that referenced this issue Feb 27, 2024
@hofi1
Fix flaky test assertion #2644 (#2665)
ebda6a4 
in org.apache.helix.rest.server.
TestInstancesAccessor#testGetAllInstances

Co-authored-by: simonh5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@hofi1