Fix flaky test assertion #2644 (#2665)

in org.apache.helix.rest.server. TestInstancesAccessor#testGetAllInstances Co-authored-by: simonh5 <[email protected]>
apache · Feb 27, 2024 · ebda6a4 · ebda6a4
1 parent 1eea253
commit ebda6a4
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/helix-rest/src/test/java/org/apache/helix/rest/server/TestInstancesAccessor.java b/helix-rest/src/test/java/org/apache/helix/rest/server/TestInstancesAccessor.java
@@ -405,8 +405,12 @@ public void testGetAllInstances() throws IOException {
 
     Set<String> instances = OBJECT_MAPPER.readValue(instancesStr,
         OBJECT_MAPPER.getTypeFactory().constructCollectionType(Set.class, String.class));
-    Assert.assertEquals(instances, _instancesMap.get(CLUSTER_NAME), "Instances from response: "
-        + instances + " vs instances actually: " + _instancesMap.get(CLUSTER_NAME));
+    Assert.assertEquals(instances.size(), _instancesMap.get(CLUSTER_NAME).size(), "Different amount of elements in "
+        + "the sets: " + instances.size() + " vs: " + _instancesMap.get(CLUSTER_NAME).size());
+    Assert.assertTrue(instances.containsAll(_instancesMap.get(CLUSTER_NAME)), "instances set does not contain all "
+        + "elements of _instanceMap");
+    Assert.assertTrue(_instancesMap.get(CLUSTER_NAME).containsAll(instances), "_instanceMap set does not contain all "
+        + "elements of instances");
     System.out.println("End test :" + TestHelper.getTestMethodName());
   }