Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To improve the usefulness of the mvLogger for use with the logging module #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DavidLutton
Copy link

Description:
To improve the usefulness of the mvLogger for use with the logging module

Changes:
Match (mvLogger) log levels with module logging
Set a distinct color for error_theme
Add demo to feed (logging module) logs into mvLogger

Concerning Areas:
Do we want to add working examples under if __name__ == "__main__": block?

Add demo to feed logs into mvLogger
Set a distinct color for error_theme
Copy link

@jhgorse jhgorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea. The bugfix is good.

The demo doesn't work though. Log events in the latest dpg do not forward to the console as intended via the queue.

dearpygui_ext/logger.py Outdated Show resolved Hide resolved
Assemble the theme name fron the log level number
Use log level constants
@DavidLutton
Copy link
Author

More explicit setup of the logging module, including adding handler for console output
This lets logging send the messages to both the queue and the console, but with a deliberately different log level for the console
@jhgorse does this work for you?
Screenshot from 2023-12-02 23-16-29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants