Merge branch 'byon-main' of https://github.com/hms-dbmi/service-workb…

…ench-on-aws into aim-ahead-dbmi-dev
hms-dbmi · Aug 11, 2023 · 5956eca · 5956eca
2 parents 22b4b1f + f55b206
commit 5956eca
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 9 deletions.
diff --git a/main/config/settings/.defaults.yml b/main/config/settings/.defaults.yml
@@ -232,3 +232,5 @@ dbEnvironmentsSc: ${self:custom.settings.dbPrefix}-EnvironmentsSc
 
 # Use Custom AMIs that are already managed by other process like golden image pipeline
 useCustomAmi: false
+
+useAwsProfile: false
diff --git a/main/solution/backend/config/settings/.defaults.yml b/main/solution/backend/config/settings/.defaults.yml
@@ -315,5 +315,3 @@ dataSourceReachabilityHandlerRoleArn: 'arn:aws:iam::${self:custom.settings.awsAc
 backendStackName: ${self:custom.settings.namespace}-backend
 
 envMgmtRoleArn: ${self:custom.settings.backendStackName}.EnvMgmtRoleArn}
-
-useAwsProfile: true
diff --git a/main/solution/backend/serverless.yml b/main/solution/backend/serverless.yml
@@ -50,7 +50,7 @@ custom:
     environmentOverrides: # when running locally
       provider:
         APP_AWS_REGION: ${self:custom.settings.awsRegion} # this is needed for local development
-        APP_AWS_PROFILE: ${self:custom.settings.awsProfile} # this is needed for local development
+        APP_AWS_PROFILE: ${self:custom.settings.awsProfile, ""} # this is needed for local development
         APP_USE_AWS_PROFILE: ${self:custom.settings.useAwsProfile, ""}
         IS_OFFLINE: true
         APP_LOCAL_ROLE_AUTO_ADJUST_TRUST: ${self:custom.settings.localRoleAutoAdjustTrust} # Auto adjust trust policy of the lambda execution role to allow assumeRole from local machine

diff --git a/main/solution/post-deployment/config/settings/.defaults.yml b/main/solution/post-deployment/config/settings/.defaults.yml
@@ -317,8 +317,6 @@ postDeploymentHandlerRoleName: ${self:custom.settings.namespace}-postDeployment-
 # The IAM role arn for the Lambda Post Deployment handler, we need to define it in the settings because it is being passed to lambdas as an env var
 postDeploymentHandlerRoleArn: 'arn:aws:iam::${self:custom.settings.awsAccountInfo.awsAccountId}:role/${self:custom.settings.postDeploymentHandlerRoleName}'
 
-useAwsProfile: true
-
 #===============================WAF=IP=Rate=Limit===========================================================
 # Per ip, per 5 minutes
 wafIpRateLimit: 1000

diff --git a/main/solution/post-deployment/serverless.yml b/main/solution/post-deployment/serverless.yml
@@ -40,7 +40,7 @@ custom:
     environmentOverrides: # when running locally
       provider:
         APP_AWS_REGION: ${self:custom.settings.awsRegion} # this is needed for local development
-        APP_AWS_PROFILE: ${self:custom.settings.awsProfile} # this is needed for local development
+        APP_AWS_PROFILE: ${self:custom.settings.awsProfile, ""} # this is needed for local development
         APP_USE_AWS_PROFILE: ${self:custom.settings.useAwsProfile, ""}
         IS_OFFLINE: true
         APP_LOCAL_ROLE_AUTO_ADJUST_TRUST: ${self:custom.settings.localRoleAutoAdjustTrust} # Auto adjust trust policy of the lambda execution role to allow assumeRole from local machine

diff --git a/main/solution/pre-deployment/config/settings/.defaults.yml b/main/solution/pre-deployment/config/settings/.defaults.yml
@@ -22,5 +22,3 @@ preDeploymentHandlerRoleName: ${self:custom.settings.namespace}-preDeployment-Ro
 
 # The IAM role arn for the Lambda Pre Deployment handler, we need to define it in the settings because it is being passed to lambdas as an env var
 preDeploymentHandlerRoleArn: 'arn:aws:iam::${self:custom.settings.awsAccountInfo.awsAccountId}:role/${self:custom.settings.preDeploymentHandlerRoleName}'
-
-useAwsProfile: true
diff --git a/main/solution/pre-deployment/serverless.yml b/main/solution/pre-deployment/serverless.yml
@@ -40,7 +40,7 @@ custom:
     environmentOverrides: # when running locally
       provider:
         APP_AWS_REGION: ${self:custom.settings.awsRegion} # this is needed for local development
-        APP_AWS_PROFILE: ${self:custom.settings.awsProfile} # this is needed for local development
+        APP_AWS_PROFILE: ${self:custom.settings.awsProfile, ""} # this is needed for local development
         APP_USE_AWS_PROFILE: ${self:custom.settings.useAwsProfile, ""}
         IS_OFFLINE: true
         APP_LOCAL_ROLE_AUTO_ADJUST_TRUST: ${self:custom.settings.localRoleAutoAdjustTrust} # Auto adjust trust policy of the lambda execution role to allow assumeRole from local machine
Original file line number	Diff line number	Diff line change
Expand Up		@@ -232,3 +232,5 @@ dbEnvironmentsSc: ${self:custom.settings.dbPrefix}-EnvironmentsSc

		# Use Custom AMIs that are already managed by other process like golden image pipeline
		useCustomAmi: false

		useAwsProfile: false
Original file line number	Diff line number	Diff line change
Expand Up		@@ -315,5 +315,3 @@ dataSourceReachabilityHandlerRoleArn: 'arn:aws:iam::${self:custom.settings.awsAc
		backendStackName: ${self:custom.settings.namespace}-backend

		envMgmtRoleArn: ${self:custom.settings.backendStackName}.EnvMgmtRoleArn}

		useAwsProfile: true
Original file line number	Diff line number	Diff line change
Expand Up		@@ -22,5 +22,3 @@ preDeploymentHandlerRoleName: ${self:custom.settings.namespace}-preDeployment-Ro

		# The IAM role arn for the Lambda Pre Deployment handler, we need to define it in the settings because it is being passed to lambdas as an env var
		preDeploymentHandlerRoleArn: 'arn:aws:iam::${self:custom.settings.awsAccountInfo.awsAccountId}:role/${self:custom.settings.preDeploymentHandlerRoleName}'

		useAwsProfile: true