[ALS-7809] DRS URI: Data Dictionary API #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returns a list of concepts with their metadata included.
I felt like Robert Martin was judging me, so I refactored to remove the boolean parameter.
Luke-Sikina
approved these changes
Nov 19, 2024
src/main/java/edu/harvard/dbmi/avillach/dictionary/concept/ConceptRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/harvard/dbmi/avillach/dictionary/concept/ConceptResultSetUtil.java
Show resolved
Hide resolved
src/main/java/edu/harvard/dbmi/avillach/dictionary/concept/ConceptService.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/harvard/dbmi/avillach/dictionary/util/JsonBlobParser.java
Outdated
Show resolved
Hide resolved
Removed the use of Optional return type to simplify code and improve readability. Updated associated tests and methods in ConceptService, ConceptRepository, and ConceptController to reflect this change.
Modified the metadata parsing logic in JsonBlobParser to handle duplicate keys by throwing an IllegalStateException. This ensures that the parser does not silently overwrite metadata entries, preserving data integrity.
# Conflicts: # dictonaryReqeust.http
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new endpoint that excepts a list of concepts and returns a list of concepts with their metadata included.