Skip to content

Commit

Permalink
ALS-6511: Added test case, removed unused code
Browse files Browse the repository at this point in the history
  • Loading branch information
ramari16 committed Aug 13, 2024
1 parent 9e2fd0c commit 7dac201
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ private Map<String, Map<Integer, List<String>>> buildResult(AsyncResult result,
int columnCount = paths.size() + 1;

ArrayList<Integer> columnIndex = abstractProcessor.useResidentCubesFirst(paths, columnCount);
ResultStore results = new ResultStore(result.getId(), columns, ids);

// todo: investigate if the parallel stream will thrash the cache if the number of executors is > number of resident cubes
columnIndex.parallelStream().forEach((columnId)->{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public void writeHeader(String[] data) {
dataFileWriter = new DataFileWriter<GenericRecord>(datumWriter);
try {
log.info("Creating temp avro file at " + file.getAbsoluteFile());
dataFileWriter.setCodec(CodecFactory.deflateCodec(5));
dataFileWriter.setCodec(CodecFactory.nullCodec());
dataFileWriter.create(entitySchema, file);
} catch (IOException e) {
throw new UncheckedIOException(e);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public void writeValidPFB() {
pfbWriter.writeMultiValueEntity(List.of(
List.of(List.of("123"), List.of("80"), List.of("Y")),
List.of(List.of("456"), List.of("70"),List.of("N", "Y")),
List.of(List.of("789"), List.of("75"), List.of())
List.of(List.of(), List.of("75"), List.of())
));
pfbWriter.close();
// todo: validate this programatically
Expand Down

0 comments on commit 7dac201

Please sign in to comment.