Generalize dimensions #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmeyer
reviewed
Sep 9, 2024
src/lib.rs
Outdated
| pub min: na::Point3<S>, | ||
| /// X-Y-Z-Maximum corner of the box. | ||
| pub max: na::Point3<S>, | ||
| fn point_best<S: 'static + Float + Debug, const D: usize>( |
There was a problem hiding this comment.
please add a function comment.
consider renaming to: apply_binary_op ?
src/lib.rs
Outdated
Comment on lines
80
to
85
| fn points_best<S: 'static + Float + Debug, const D: usize>( | ||
| points: &[na::Point<S, D>], | ||
| op: fn(S, S) -> S, | ||
| ) -> na::Point<S, D> { | ||
| points.iter().fold( | ||
| na::Point::from([-op(S::infinity(), S::neg_infinity()); D]), |
There was a problem hiding this comment.
This is pretty neat. But also quite clever.
How about renaming it to:
fn fold_points(initial, points, op) -> Point?
Also make points: Iterator<Point>?
also please add a function comment
hmeyer
reviewed
Sep 16, 2024
src/lib.rs
Outdated
| } | ||
|
|
||
| fn points_min<S: 'static + Float + Debug, const D: usize>( | ||
| points: &[na::Point<S, D>], |
There was a problem hiding this comment.
This should also be points: impl Iterator<Item = &'a na::Point<S, D>>, no?
src/lib.rs
Outdated
| } | ||
|
|
||
| fn points_max<S: 'static + Float + Debug, const D: usize>( | ||
| points: &[na::Point<S, D>], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have generalized bbox to the generic dimension. Please check if the implementation is correct, especially for the distance function. I think in the future it would be useful to modify the distance function to calculate the exact distance, the current implementation is confusing. I was not able to generalize the transform function, so it is only defined in 3d for now.