hotfix/JS-131: Updated checkbox labels to fix broken checkboxes (#841)

* Updated checkbox labels to fix broken checkboxes * Update contact-logs-tab.njk
hmcts · Nov 15, 2024 · dece167 · dece167
1 parent 5ef8608
commit dece167
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 6 deletions.
diff --git a/client/templates/custom-components/sortable-table/template.njk b/client/templates/custom-components/sortable-table/template.njk
@@ -5,7 +5,7 @@
   <div class="govuk-checkboxes__item govuk-checkboxes--small moj-multi-select__checkbox">
     <input type="checkbox" class="govuk-checkboxes__input select-check juror-select-check" id="check-all-jurors" name="selectAllCheckbox" 
       {% if params.totalCheckedJurors === params.totalJurors %}checked{% endif %}/>
-    <label class="govuk-label govuk-checkboxes__label" for="selectAllCheckbox">
+    <label class="govuk-label govuk-checkboxes__label" for="check-all-jurors">
       <span class="govuk-visually-hidden">Select All</span>
     </label>
   </div>

diff --git a/client/templates/documents/exemption/exemption-list.njk b/client/templates/documents/exemption/exemption-list.njk
@@ -80,7 +80,7 @@
               <th scope="col" class="govuk-table__header jd-assign-replies-table-head jd-middle-align">
                 <div class="govuk-checkboxes__item govuk-checkboxes--small moj-multi-select__checkbox">
                   <input type="checkbox" class="govuk-checkboxes__input select-check juror-select-check" id="check-all-jurors" name="check-all-jurors"/>
-                  <label class="govuk-label govuk-checkboxes__label govuk-!-padding-0">
+                  <label class="govuk-label govuk-checkboxes__label govuk-!-padding-0" for="check-all-jurors">
                     <span class="govuk-visually-hidden">Select All</span>
                   </label>
                 </div>

diff --git a/client/templates/juror-management/_partials/contact-logs-tab.njk b/client/templates/juror-management/_partials/contact-logs-tab.njk
@@ -1,4 +1,5 @@
 {% from "moj/components/timeline/macro.njk" import mojTimeline %}
+{% from "govuk/components/tag/macro.njk" import govukTag %}
 
 <section>
   <div class="mod-juror-record__title govuk-body">

diff --git a/client/templates/juror-management/dismiss-jurors/jurors-table.njk b/client/templates/juror-management/dismiss-jurors/jurors-table.njk
@@ -17,7 +17,7 @@
         <div class="govuk-checkboxes__item govuk-checkboxes--small moj-multi-select__checkbox">
           <input type="checkbox" class="govuk-checkboxes__input" id="check-all-jurors"
             aria-label="check-all-jurors" {% if totalCheckedJurors === totalJurors %}checked{% endif %}/>
-          <label class="govuk-label govuk-checkboxes__label govuk-!-padding-0" for="jurors-all">
+          <label class="govuk-label govuk-checkboxes__label govuk-!-padding-0" for="check-all-jurors">
             <span class="govuk-visually-hidden">Select all jurors</span>
           </label>
         </div>

diff --git a/client/templates/juror-management/expense-record/_partials/expenses-table-macros.njk b/client/templates/juror-management/expense-record/_partials/expenses-table-macros.njk
@@ -23,7 +23,7 @@
             <div class="govuk-checkboxes__item govuk-checkboxes--small moj-multi-select__checkbox">
               <input type="checkbox" class="govuk-checkboxes__input" id="check-all-expenses"
                 aria-label="check-all-expenses" {% if params.totalCheckedExpenses === params.totalExpenses %}checked{% endif %}/>
-              <label class="govuk-label govuk-checkboxes__label govuk-!-padding-0" for="expenses-all">
+              <label class="govuk-label govuk-checkboxes__label govuk-!-padding-0" for="check-all-expenses">
                 <span class="govuk-visually-hidden">Select all expenses</span>
               </label>
             </div>

diff --git a/client/templates/messaging/_partials/jurors-table.njk b/client/templates/messaging/_partials/jurors-table.njk
@@ -149,7 +149,7 @@
         html: 
           '<div class="govuk-checkboxes__item govuk-checkboxes--small moj-multi-select__checkbox">' + 
             '<input type="checkbox" class="govuk-checkboxes__input" id="check-all-jurors" aria-label="check-all-jurors"' + _allChecked + '/>' +
-            '<label class="govuk-label govuk-checkboxes__label govuk-!-padding-0" for="jurors-all">' +
+            '<label class="govuk-label govuk-checkboxes__label govuk-!-padding-0" for="check-all-jurors">' +
               '<span class="govuk-visually-hidden">Select all jurors</span>' +
             '</label>' +
           '</div>',

diff --git a/client/templates/trial-management/generate-panel/select-pools.njk b/client/templates/trial-management/generate-panel/select-pools.njk
@@ -53,7 +53,7 @@
               <td class="govuk-table__cell">
                 <div class="govuk-checkboxes__item govuk-checkboxes--small moj-multi-select__checkbox">
                   <input type="checkbox" class="govuk-checkboxes__input" id="select-{{pool.pool_number}}" name="selectedPools" value="{{pool.pool_number}}">
-                  <label class="govuk-label govuk-checkboxes__label govuk-!-padding-0" for="{{pool.pool_number}}">
+                  <label class="govuk-label govuk-checkboxes__label govuk-!-padding-0" for="select-{{pool.pool_number}}">
                     <span class="govuk-visually-hidden">Select {{pool.pool_number}}</span>
                   </label>
                 </div>