Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define MQTT and sensor configuration separately from implementation #8

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Apr 19, 2024

About

The data logger uses a YAML file for configuration now, for example like etc/mois.yaml. You will then invoke it like:

pip install ds18b20-datalogger
wget https://github.com/hiveeyes/ds18b20-datalogger/raw/main/etc/mois.yaml
ds18b20-datalogger run mois.yaml

More

  • Add subcommand make-config, for creating a configuration blueprint
  • Add subcommand make-dashboard, for creating a Grafana Dashboard
  • Add subcommand read, for acquiring and displaying a reading on STDOUT
  • Tests: Bring code coverage back to 100%
  • Improve documentation

The data logger uses a YAML file now, for example like `etc/mois.yaml`.
You will then invoke it like:

  ds18b20-datalogger run etc/mois.yaml
@amotl amotl requested a review from bee-mois April 19, 2024 02:03
@amotl amotl marked this pull request as ready for review April 19, 2024 02:03
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (63e9a71) to head (6f88b05).

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         4    +2     
  Lines          153       148    -5     
=========================================
- Hits           153       148    -5     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl marked this pull request as draft April 19, 2024 02:31
@amotl amotl force-pushed the refactoring-four branch from 627aa3e to 6f88b05 Compare April 19, 2024 23:42
@amotl amotl marked this pull request as ready for review April 19, 2024 23:43
@amotl amotl merged commit a607fb0 into main Apr 19, 2024
4 checks passed
@amotl amotl deleted the refactoring-four branch April 19, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant