-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update to be Stacks.js v7 compatible #389
Conversation
janniks
commented
Oct 18, 2024
•
edited by github-actions
bot
Loading
edited by github-actions
bot
- update to use both legacy and next network
- update post conditions and clarity serialization
- switch to npm from yarn
🦋 Changeset detectedLatest commit: cc06270 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great !
If I understand correctly this is backward compatible (with stacks.js v6) at the cost of an increase in bundle size in connect because both versions are imported, which is perfectly fine. But does it mean that stacks v7 is not backward compatible with v6 format ?
Btw I'm curious, why was yarn removed ?
import { AnchorMode, PostConditionMode } from '@stacks/transactions'; | ||
import { userSession } from './userSession'; | ||
|
||
openSTXTransfer({ | ||
network: new StacksTestnet(), // which network to use; use `new StacksMainnet()` for mainnet | ||
network: 'testnet', // which network to use; ('mainnet' or 'testnet') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is much simpler now ! 🎉
Had a weird yarn problem for a while, where we could never recreate the lock file. It was hard to update deps. And npm is the default and everyone has it, one step less 😉 Yep, I think the actual web bundle won't be too much bigger, as it only uses a few imports. But for now we want backwards comp. A next version of Connect would reinvent a bunch of stuff and be non-backwards compatible (while the wallet still are probably), but hopefully more on that front soon! |
@janniks makes sense ! I just wanted to know, as I rarely use yarn nowadays, it's either pnpm or npm. npm is quite fast now, and it's much simpler and predictable. |