Add tests for HiPS tile <-> Numpy conversions #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I wanted to make the
healpix_to_hips
work for RGB JPEG and RGBA PNG data. I'll make a pull request for that shortly.However, I noticed that there seems to be a bug in our
HipsTile.from_numpy
orHipsTile.to_numpy
for the RGB JPEG case. This PR shows the issue via a regression test. It works for FITS and also for RGBA PNG as expected.Looking for old issues I saw #112, possibly this is the same issue. I did try adding
.copy
calls before and after theflipud
calls infrom_numpy
, no change, so transposed Numpy arrays don't seem to be the issue.@tboch and maybe if you have time @adl1995 or @adonath - If you have time, could you please have a look at this and comment if you have any idea?
This is blocking the work on HEALPix -> HiPS and the v0.3 release, so we should try to figure this out ASAP.