Merge pull request #26 from hintmedia/change/do-not-expose-unnecessar…

…y-ports Do not expose ports for support services
hintmedia · Jul 28, 2020 · 40d55b3 · 40d55b3
2 parents 918fb19 + cdddb98
commit 40d55b3
Show file tree

Hide file tree

Showing 9 changed files with 4 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ## [Unreleased]
 ### Added
 ### Changed
+- default to exposing only necessary ports [PR26](https://github.com/hintmedia/railsdock/pull/26)
 ### Deprecated
 ### Removed
 ### Fixed

diff --git a/lib/railsdock/templates/install/memcached/docker-compose.yml.erb b/lib/railsdock/templates/install/memcached/docker-compose.yml.erb
@@ -5,7 +5,5 @@
       context: <%= dockerfile_dir %>memcached
       args:
         - MEMCACHED_VERSION=${MEMCACHED_VERSION}
-    ports:
-      - "${MEMCACHED_HOST_PORT}:11211"
     volumes:
       - memcached:/var/lib/memcached
diff --git a/lib/railsdock/templates/install/memcached/memcached.env b/lib/railsdock/templates/install/memcached/memcached.env
@@ -2,5 +2,4 @@
 
 ### MEMCACHED #################################################################
 
-MEMCACHED_VERSION=1.5
-MEMCACHED_HOST_PORT=11211
+MEMCACHED_VERSION=1.5
diff --git a/lib/railsdock/templates/install/mysql/docker-compose.yml.erb b/lib/railsdock/templates/install/mysql/docker-compose.yml.erb
@@ -7,7 +7,5 @@
         - MYSQL_VERSION=${MYSQL_VERSION}
     environment:
       - MYSQL_ROOT_PASSWORD=${MYSQL_ROOT_PASSWORD}
-    ports:
-      - "${MYSQL_HOST_PORT}:3306"
     volumes:
       - mysql:/var/lib/mysql
diff --git a/lib/railsdock/templates/install/mysql/mysql.env b/lib/railsdock/templates/install/mysql/mysql.env
@@ -3,5 +3,4 @@
 ### MYSQL #####################################################################
 
 MYSQL_VERSION=5.7
-MYSQL_HOST_PORT=3306
 MYSQL_ROOT_PASSWORD=Password1
diff --git a/lib/railsdock/templates/install/postgres/docker-compose.yml.erb b/lib/railsdock/templates/install/postgres/docker-compose.yml.erb
@@ -7,7 +7,5 @@
         - POSTGRES_VERSION=${POSTGRES_VERSION}
     environment:
       - POSTGRES_HOST_AUTH_METHOD=trust
-    ports:
-      - "${POSTGRES_HOST_PORT}:5432"
     volumes:
       - postgres:/var/lib/postgresql/data
diff --git a/lib/railsdock/templates/install/postgres/postgres.env b/lib/railsdock/templates/install/postgres/postgres.env
@@ -2,5 +2,4 @@
 
 ### POSTGRES ##################################################################
 
-POSTGRES_VERSION=11
-POSTGRES_HOST_PORT=5432
+POSTGRES_VERSION=11
diff --git a/lib/railsdock/templates/install/redis/docker-compose.yml.erb b/lib/railsdock/templates/install/redis/docker-compose.yml.erb
@@ -5,7 +5,5 @@
       context: <%= dockerfile_dir %>redis
       args:
         - REDIS_VERSION=${REDIS_VERSION}
-    ports:
-      - "${REDIS_HOST_PORT}:6379"
     volumes:
       - redis:/data
diff --git a/lib/railsdock/templates/install/redis/redis.env b/lib/railsdock/templates/install/redis/redis.env
@@ -2,5 +2,4 @@
 
 ### REDIS #####################################################################
 
-REDIS_VERSION=4
-REDIS_HOST_PORT=6379
+REDIS_VERSION=4