Skip to content

Commit

Permalink
Perform numerical comparison of version numbers in upgrade process. F…
Browse files Browse the repository at this point in the history
…or Ravel #664.
  • Loading branch information
highperformancecoder committed Jan 7, 2025
1 parent ada4b74 commit 9e7f428
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ecolab
Submodule ecolab updated 1 files
+1 −1 classdesc
Original file line number Diff line number Diff line change
Expand Up @@ -1310,8 +1310,8 @@ export class CommandsManager {
let minskyVersionRE=/(\d+)\.(\d+)\.(\d+)([.-])/;
let [,major,minor,patch]=minskyVersionRE.exec(minskyFile);
let [,currMajor,currMinor,currPatch,terminator]=minskyVersionRE.exec((await minsky.minskyVersion())+'.');
if (major>currMajor || major===currMajor &&
(minor>currMinor || minor===currMinor && patch>currPatch) ||
if (+major>+currMajor || major===currMajor &&
(+minor>+currMinor || minor===currMinor && +patch>+currPatch) ||
terminator==='-' && // currently a beta release, so install if release nos match (since betas precede releases)
major===currMajor && minor===currMinor && patch==currPatch
) {
Expand Down

0 comments on commit 9e7f428

Please sign in to comment.