Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for body of type #'v1_0.amqp_value'{} #114

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

scudelletti
Copy link
Contributor

@scudelletti scudelletti commented Oct 15, 2024

Doc: https://hexdocs.pm/amqp10_client/amqp10_msg.html#body-1

The previous version supported only a binary list with a single item, this PR adds supports for the #'v1_0.amqp_value'{} record.

ℹ️ This PR doesn't add support to [#'v1_0.amqp_sequence'{}].

@scudelletti scudelletti force-pushed the ds-amqp-value-support branch 4 times, most recently from fba1b55 to 020e658 Compare October 15, 2024 12:39
@scudelletti scudelletti force-pushed the ds-amqp-value-support branch from 020e658 to 9f7e848 Compare October 15, 2024 12:41
@scudelletti scudelletti requested a review from slashmili October 15, 2024 13:44
Copy link
Member

@slashmili slashmili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

I also agree with your point about raising when the message format is v1_0.amqp_sequence

Copy link
Member

@slashmili slashmili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@scudelletti scudelletti merged commit 599a2b7 into main Oct 16, 2024
1 check passed
@scudelletti scudelletti deleted the ds-amqp-value-support branch October 16, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants