Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SASL to be set to :none and durable to be configured by user #113

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Allow SASL to be set to :none and durable to be configured by user #113

merged 4 commits into from
Oct 15, 2024

Conversation

scudelletti
Copy link
Contributor

@scudelletti scudelletti commented Oct 4, 2024 •
edited
Loading

This PR allows the user of specify the durability for the receiver and the option none to SASL.

Durable Options:

SASL Options(we currently only support encrypted_sasl):

@scudelletti scudelletti requested a review from slashmili October 4, 2024 09:00
slashmili
slashmili approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@slashmili slashmili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@scudelletti scudelletti merged commit fb88d3f into main Oct 15, 2024
1 check passed
@scudelletti scudelletti deleted the ds-allow-empty-sasl branch October 15, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slashmili slashmili slashmili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scudelletti @slashmili