fix(dart) - add highlighting for class and function names #4169
Conversation
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +258 B View Changes
|
src/languages/dart.js
Outdated
| { | ||
| // prevent built-in types with capital letter from being selected as title.class | ||
| match: BUILT_IN_TYPES_REGEX, | ||
| skip: true |
There was a problem hiding this comment.
Why wouldn't a built-in class also get title.class? That or perhaps built_in I'd think...
There was a problem hiding this comment.
Using this snippet as an example:
class Person {
String name;
int age;
Person(this.name, this.age);
}Currently the library already marks String as built_in, so I added this regex to prevent String from being matched as title.class. I may have misunderstood what skip is used for (still learning how the library works) - I set skip: true because otherwise String wasn't decorated at all. I thought we wanted to preserve the current behavior, but if it's ok to use title.class for built-in classes I can remove this part
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +258 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +274 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +163 B View Changes
|
Resolves #4091
Changes
Before class and function names were not decorated and this could impact readability
Now these elements are correctly highlighted
Checklist
CHANGES.md