Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tell knock about the timezone. #9556

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Tell knock about the timezone. #9556

merged 2 commits into from
Oct 17, 2024

Conversation

burtonator
Copy link
Collaborator

Link to Issue

Closes: #9532

Description of Changes

  • adds identify on the client which pushes the timezone to knock.

"How We Fixed It"

Test Plan

  • I already manually tested this locally. However, the way to test is to get your user id, check that your knock account has your timezone properly by going into users and looking manually.

Deployment Plan

Other Considerations

@github-actions github-actions bot marked this pull request as draft October 15, 2024 20:43
@burtonator burtonator marked this pull request as ready for review October 16, 2024 17:39
@burtonator burtonator requested a review from timolegros October 16, 2024 17:39
mzparacha
mzparacha approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@mzparacha mzparacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, codewise lgtm.

@burtonator burtonator merged commit 93ca306 into master Oct 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timolegros timolegros timolegros approved these changes

@mzparacha mzparacha mzparacha approved these changes

@masvelio masvelio Awaiting requested review from masvelio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Knock timezone not being set for users so send windows don't work.
3 participants
@burtonator @mzparacha @timolegros