Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot now shows proper amount in message #7019

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Israellund
Copy link
Collaborator

Link to Issue

Closes: #6111

Description of Changes

-When a user tries to create a proposal on Snapshot without having the minimum amount for that space, the message on Common now corresponds with the message/amount that is seen on Snapshot.

"How We Fixed It"

-changed the message to display space.validation.params.minScore

Test Plan

  • Make sure you have a Snapshot space saved in Integrations. If you don't have one you can use mangrove.eth
  • go to a thread or create one and connect a Snapshot
  • notice that it now reads to be a certain amount, rather than the default 0.
  • If you would like more confirmation that the amounts match up, you can go to the Snapshot space on Snapshot and try to make a proposal there, and compare the two messages. Try here on Mangrove DAO https://snapshot.org/#/mangrove.eth
Screenshot 2024-03-07 at 9 56 57 AM Screenshot 2024-03-07 at 9 57 25 AM

@jnaviask jnaviask merged commit 44b6453 into master Mar 12, 2024
8 checks passed
@jnaviask jnaviask deleted the israel.6111.snapshot-message-mismatch branch March 12, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create snapshot message from CW not the same as on Snapshot
3 participants