snapshot message now changes when space is changed in dropdown #7007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miaplacidus
approved these changes
Mar 14, 2024
packages/commonwealth/client/scripts/views/modals/new_snapshot_proposal_modal.tsx
Outdated
Show resolved
Hide resolved
masvelio
reviewed
Mar 15, 2024
packages/commonwealth/client/scripts/views/modals/new_snapshot_proposal_modal.tsx
Outdated
Show resolved
Hide resolved
masvelio
approved these changes
Mar 18, 2024
Israellund
deleted the
israel.6488.switching-snapshot-spaces-in-dropdown
branch
rbennettcw
added a commit
that referenced
this pull request
Mar 20, 2024
* stakeholder ddd script wip * move scripts to packages dir * ddd command wip * tsconfig and script update * script fixes * further script fixes wip * update dump-db (#7113) * 7136 infiniteloopbug (#7138) * Fixed overflow issue * Fixed z-index * Fixes loop * cleanup * Fix one off dynos (#7133) * move ts-node and tsconfig-paths to dep * yarn.lock fix * add -T option for ts-node scripts + clean-up package.json scripts * Fixed issue with getBulkThreads (#7148) * fix ddd wip * snapshot message now changes when space is changed in dropdown (#7007) * snapshot message now changes when space is changed in dropdown * deleted commented out code * deleted console log * refactored code to not be redundant * destructured props to pass tests and clean up codebase * include rawLog in UI error (#7156) * Discord Bot Disconnect (#7144) * discord disconnect route + add admin check for setConfig * return response + fix eslint errors * fix redirect + removal + setting * eslint * eslint * ensure delete + refresh renders integration as deleted * eslint * move API request to /state (react-query) + use useMemo to fetch urlSearchParams * is disconnecting text * eslint * move path to ApiEndpoints * Implement a deep seed util for unit testing (#7139) * deep seed * keep seedDb as legacy, fix new tests with seed * clean seeds * fix test * fix lint * remove comments * remove toJSON * remove magic db name and fix comments --------- Co-authored-by: rotorsoft <[email protected]> * Broker Port (#7039) * rabbitmq adapter * snapshot consumer broker + event handling updates * discordConsumer * discordConsumer update + commonwealthConsumer fixes * fix some types * Discord listener message publishing * Snapshot producer updates * Remove old RabbitMQ controller + associated types * unit tests + RabbitMQAdapter updates + Discord message event schema fix * RMQ URL * fix test * merge resolution * type fixes --------- Co-authored-by: rotorsoft <[email protected]> * Deprecate custom support for Axie Infinity forum. (#7159) * Deprecate custom support for Axie Infinity forum. * Update migration to select correct eth chain node. * added snapshot link value in breadcrumbs/utils (#7163) * this should force prettier to fail on our branch... (#7118) * this should force prettier to fail on our branch... * fixed yarn.lock issue. * I don't think we were running all the rules before - at least on MacOS but this should fix it. * prettier fix... (#7177) * prettier fix... * turn prettier to warn... * jQuery removal (#7162) * remove jquery from login * remove jquery from web_wallets * remove jquery from coinbase_web_wallet and metamask_web_wallet * remove jquery from contracts * remove jquery from polls * remove jquery from user * remove jquery account * remove jquery from components * remove jquery from delete_address_modal * remove jquery from notifications * remove jquery from dependencies * removed dead code --------- Co-authored-by: Jake Naviasky <[email protected]> * fix tests (#7175) Co-authored-by: rotorsoft <[email protected]> * Fix snapshot tests (#7143) * fix snapshot tests * add snapshot tests to CI * add test step to CI * update path * update path * set node version * remove `main` and add `private` in snapshot package.json * add type check for snapshot-listener * install deps * try `yarn build-ci` to resolve CI bug * try building only snapshot before testing * use in-memory broker for tests * broker port merge resolution * Add libs tests to CI (#7174) * Add libs tests to CI * Fixed PR comment * 7136 infiniteloopbug taketwo (#7150) * Fixed overflow issue * Fixed z-index * Fix * CLG * Removed useEffect * Got rid of params useBrowserWindow * CR * Fix for topic loading. Types are wrong. (#7153) * This is a HACKED fix for topic loading. The types are wrong and we're sending them to the backend incorrectly * In theory this should fix the loading issue... * this might be the proper fix but could be a different issue. * trigger CI * Fixes Z-Index for CWModal (#7166) * fix types and imports * fix types * Create Outbox (#7044) * Outbox table migration * auto trigger maintenance * archive-outbox script + bump @types/node * dockerfile for postgres and pg_partman extension + remove old docker file * new docker file * update installation * update installation * update * test another docker file * outbox sequelize model + zod schema * update * Fixed docker file * working Docker file * remove user 1001 * create extension if exist + use cw_postgres image in CI * update pg_partman interval * update pg_partman type * update outbox sequelize model * remove id column from sequelize model definition * archive-outbox updates * package.json script for outbox archival * use npx * add -T option for archival-outbox yarn script * logging * load env var with dotenv * modify dump name * fix searching AWS for existing object * merge conflict resolution * fix import * fix another import * remove unnecessary comments * Outbox hardcode event_name + event_payload schema * Trigger CI --------- Co-authored-by: kassad <[email protected]> * Fix CI (#7178) * Trigger CI * fix CI * add RMQ to CI * use common_test in CI * add test db to sequelize.json * add NODE_ENV=test to `build-ci` migrate-db command * load env var in database.ts * use common_test DB for all CI jobs * remove TaggedThreads model + set selected_community_id = null for test Users (resolves fkey issue) * remove TaggedThreads model + set selected_community_id = null for test Users (resolves fkey issue) * fix model test * fix CommunityStakes model * Postgresql numberic = Sequelize DECIMAL * revert some changes * update vote weight data type * increase snapshot timeout * revert checkDb uri update * move getCommunityMembers query * trpc router * Fix thread reaction count update (#7171) * query fix + script fix * fix query output wip * Added 'My Community Stake' option in profile dropdown (#7189) * Added 'My Community Stake' option in profile dropdown * Updated to use `useFlag` for .env flag check * use trpc for members fetch * add stake balance in UI * fix non-staked members page --------- Co-authored-by: Timothee Legros <[email protected]> Co-authored-by: Zachary Lee <[email protected]> Co-authored-by: Kurtis Assad <[email protected]> Co-authored-by: Israel Lund <[email protected]> Co-authored-by: Mark Hagelberg <[email protected]> Co-authored-by: Roger Torres <[email protected]> Co-authored-by: rotorsoft <[email protected]> Co-authored-by: Jake Naviasky <[email protected]> Co-authored-by: Kevin Burton <[email protected]> Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Malik Zulqurnain <[email protected]>
rbennettcw
added a commit
that referenced
this pull request
Mar 26, 2024
* add migration group is_system_managed * create stakeholder group on community stake created * prevent update/delete for system-managed groups * add script to generate stakeholder groups * searchProfiles refactor WIP * stake balance WIP * threshold rule WIP * batch wip * stake balance WIP * lint * fix type * fix generate stakeholder group on create stake * fix for test * cleanup * can fetch stake balances * split out into profiles vs members routes * query fix * set required requirements * lint * prevent failure in community stake request * typo * catch err * use proper copy * support multiple stakeholder groups per community * lint * fix script * fix import * fix page num * Autogen stakeholder groups DDD refactor (#7127) * stakeholder ddd script wip * move scripts to packages dir * ddd command wip * tsconfig and script update * script fixes * further script fixes wip * update dump-db (#7113) * 7136 infiniteloopbug (#7138) * Fixed overflow issue * Fixed z-index * Fixes loop * cleanup * Fix one off dynos (#7133) * move ts-node and tsconfig-paths to dep * yarn.lock fix * add -T option for ts-node scripts + clean-up package.json scripts * Fixed issue with getBulkThreads (#7148) * fix ddd wip * snapshot message now changes when space is changed in dropdown (#7007) * snapshot message now changes when space is changed in dropdown * deleted commented out code * deleted console log * refactored code to not be redundant * destructured props to pass tests and clean up codebase * include rawLog in UI error (#7156) * Discord Bot Disconnect (#7144) * discord disconnect route + add admin check for setConfig * return response + fix eslint errors * fix redirect + removal + setting * eslint * eslint * ensure delete + refresh renders integration as deleted * eslint * move API request to /state (react-query) + use useMemo to fetch urlSearchParams * is disconnecting text * eslint * move path to ApiEndpoints * Implement a deep seed util for unit testing (#7139) * deep seed * keep seedDb as legacy, fix new tests with seed * clean seeds * fix test * fix lint * remove comments * remove toJSON * remove magic db name and fix comments --------- Co-authored-by: rotorsoft <[email protected]> * Broker Port (#7039) * rabbitmq adapter * snapshot consumer broker + event handling updates * discordConsumer * discordConsumer update + commonwealthConsumer fixes * fix some types * Discord listener message publishing * Snapshot producer updates * Remove old RabbitMQ controller + associated types * unit tests + RabbitMQAdapter updates + Discord message event schema fix * RMQ URL * fix test * merge resolution * type fixes --------- Co-authored-by: rotorsoft <[email protected]> * Deprecate custom support for Axie Infinity forum. (#7159) * Deprecate custom support for Axie Infinity forum. * Update migration to select correct eth chain node. * added snapshot link value in breadcrumbs/utils (#7163) * this should force prettier to fail on our branch... (#7118) * this should force prettier to fail on our branch... * fixed yarn.lock issue. * I don't think we were running all the rules before - at least on MacOS but this should fix it. * prettier fix... (#7177) * prettier fix... * turn prettier to warn... * jQuery removal (#7162) * remove jquery from login * remove jquery from web_wallets * remove jquery from coinbase_web_wallet and metamask_web_wallet * remove jquery from contracts * remove jquery from polls * remove jquery from user * remove jquery account * remove jquery from components * remove jquery from delete_address_modal * remove jquery from notifications * remove jquery from dependencies * removed dead code --------- Co-authored-by: Jake Naviasky <[email protected]> * fix tests (#7175) Co-authored-by: rotorsoft <[email protected]> * Fix snapshot tests (#7143) * fix snapshot tests * add snapshot tests to CI * add test step to CI * update path * update path * set node version * remove `main` and add `private` in snapshot package.json * add type check for snapshot-listener * install deps * try `yarn build-ci` to resolve CI bug * try building only snapshot before testing * use in-memory broker for tests * broker port merge resolution * Add libs tests to CI (#7174) * Add libs tests to CI * Fixed PR comment * 7136 infiniteloopbug taketwo (#7150) * Fixed overflow issue * Fixed z-index * Fix * CLG * Removed useEffect * Got rid of params useBrowserWindow * CR * Fix for topic loading. Types are wrong. (#7153) * This is a HACKED fix for topic loading. The types are wrong and we're sending them to the backend incorrectly * In theory this should fix the loading issue... * this might be the proper fix but could be a different issue. * trigger CI * Fixes Z-Index for CWModal (#7166) * fix types and imports * fix types * Create Outbox (#7044) * Outbox table migration * auto trigger maintenance * archive-outbox script + bump @types/node * dockerfile for postgres and pg_partman extension + remove old docker file * new docker file * update installation * update installation * update * test another docker file * outbox sequelize model + zod schema * update * Fixed docker file * working Docker file * remove user 1001 * create extension if exist + use cw_postgres image in CI * update pg_partman interval * update pg_partman type * update outbox sequelize model * remove id column from sequelize model definition * archive-outbox updates * package.json script for outbox archival * use npx * add -T option for archival-outbox yarn script * logging * load env var with dotenv * modify dump name * fix searching AWS for existing object * merge conflict resolution * fix import * fix another import * remove unnecessary comments * Outbox hardcode event_name + event_payload schema * Trigger CI --------- Co-authored-by: kassad <[email protected]> * Fix CI (#7178) * Trigger CI * fix CI * add RMQ to CI * use common_test in CI * add test db to sequelize.json * add NODE_ENV=test to `build-ci` migrate-db command * load env var in database.ts * use common_test DB for all CI jobs * remove TaggedThreads model + set selected_community_id = null for test Users (resolves fkey issue) * remove TaggedThreads model + set selected_community_id = null for test Users (resolves fkey issue) * fix model test * fix CommunityStakes model * Postgresql numberic = Sequelize DECIMAL * revert some changes * update vote weight data type * increase snapshot timeout * revert checkDb uri update * move getCommunityMembers query * trpc router * Fix thread reaction count update (#7171) * query fix + script fix * fix query output wip * Added 'My Community Stake' option in profile dropdown (#7189) * Added 'My Community Stake' option in profile dropdown * Updated to use `useFlag` for .env flag check * use trpc for members fetch * add stake balance in UI * fix non-staked members page --------- Co-authored-by: Timothee Legros <[email protected]> Co-authored-by: Zachary Lee <[email protected]> Co-authored-by: Kurtis Assad <[email protected]> Co-authored-by: Israel Lund <[email protected]> Co-authored-by: Mark Hagelberg <[email protected]> Co-authored-by: Roger Torres <[email protected]> Co-authored-by: rotorsoft <[email protected]> Co-authored-by: Jake Naviasky <[email protected]> Co-authored-by: Kevin Burton <[email protected]> Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Malik Zulqurnain <[email protected]> * fix export * remove old files * remove old code * use command in handler * catch err * lint * consolidate query * update tsconfig * use buildPaginatedResponse from core --------- Co-authored-by: Timothee Legros <[email protected]> Co-authored-by: Zachary Lee <[email protected]> Co-authored-by: Kurtis Assad <[email protected]> Co-authored-by: Israel Lund <[email protected]> Co-authored-by: Mark Hagelberg <[email protected]> Co-authored-by: Roger Torres <[email protected]> Co-authored-by: rotorsoft <[email protected]> Co-authored-by: Jake Naviasky <[email protected]> Co-authored-by: Kevin Burton <[email protected]> Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Malik Zulqurnain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #6488
Description of Changes
"How We Fixed It"
-added an
app.snapshot.init()call to when the dropdown value is changedTest Plan
-make sure you have more than one snapshot space saved in Integrations. You can use shellprotocol.eth and commonspacetester.eth if you don't have spaces.
-go to a thread and add a Snapshot
-switch the snapshot spaces in the dropdown within the modal
-notice that the corresponding messages now change when the value is changed.
Screen.Recording.2024-03-06.at.11.33.01.PM.mov