Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added safari specific styles to fix content height #6987

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

mzparacha
Copy link
Contributor

@mzparacha mzparacha commented Mar 5, 2024

Link to Issue

Closes: #6986

Description of Changes

Adds safari-specific styles to fix content height on certain versions (<=16.3) that don't support the dvh unit. I used 12.x as the lowest supported safari version, as it dates back to 2015 (release year), we can update this if required.

See here
image

See here
image

"How We Fixed It"

N/A

Test Plan

Pre-req: Test on safari versions < 16.3 (released around 2022)

Deployment Plan

N/A

Other Considerations

N/A

@github-actions github-actions bot marked this pull request as draft March 5, 2024 19:48
@mzparacha mzparacha self-assigned this Mar 5, 2024
@mzparacha mzparacha marked this pull request as ready for review March 5, 2024 19:49
Copy link
Collaborator

@ilijabojanovic ilijabojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Israellund Israellund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzparacha mzparacha merged commit 3e8e767 into master Mar 12, 2024
6 of 7 checks passed
@mzparacha mzparacha deleted the malik.6986.fix-page-content-visibility branch March 12, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page content is cut-off in Safari
3 participants