Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6826 feature flag for growl #6827

Merged
merged 9 commits into from
Feb 21, 2024
Merged

6826 feature flag for growl #6827

merged 9 commits into from
Feb 21, 2024

Conversation

lzach83
Copy link
Contributor

@lzach83 lzach83 commented Feb 21, 2024

Link to Issue

Closes: #6826

Description of Changes

  • Added check for the Stake feature flag

"How We Fixed It"

  • Brought in the useFlag hook and passed communityStake as a param

Test Plan

  • Turn FLAG_COMMUNITY_STAKE to false
  • Ensure the growl does not render
  • Turn FLAG_COMMUNITY_STAKE to true
  • Ensure the growl does render

@lzach83 lzach83 self-assigned this Feb 21, 2024
@jnaviask jnaviask merged commit 5aae853 into master Feb 21, 2024
7 of 8 checks passed
@jnaviask jnaviask deleted the 6826-featureFlagForGrowl branch February 21, 2024 17:55
jnaviask pushed a commit that referenced this pull request Feb 21, 2024
@lzach83 @jnaviask
6826 feature flag for growl (#6827)
6167791 
* Fixed overflow issue

* Added feature flag for growl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnaviask jnaviask jnaviask approved these changes

@Miaplacidus Miaplacidus Awaiting requested review from Miaplacidus

@ilijabojanovic ilijabojanovic Awaiting requested review from ilijabojanovic

@mzparacha mzparacha Awaiting requested review from mzparacha

@Israellund Israellund Awaiting requested review from Israellund

@CowMuon CowMuon Awaiting requested review from CowMuon

Assignees

@lzach83 lzach83

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add feature flag for Growl notifications
2 participants
@lzach83 @jnaviask