Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown-only proposal description editor #6813

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Markdown-only proposal description editor #6813

merged 1 commit into from
Feb 29, 2024

Conversation

mhagel
Copy link
Contributor

@mhagel mhagel commented Feb 20, 2024

Link to Issue

Closes: #6635

Description of Changes

  • Makes Cosmos Onchain Proposal description input markdown-only
  • slightly widens form to make editor toolbar fit in one line

"How We Fixed It"

  • Tested by copying some proposal markdown content from past Juno summaries

Test Plan

  • CA (click around) tested on local:

Deployment Plan

Other Considerations

  • I noticed juno proposals have \n newline characters a lot. Our editor doesn't support that, but the Preview window should resolve any confusion

@mhagel mhagel marked this pull request as ready for review February 20, 2024 23:26
@mhagel mhagel requested review from lzach83 and rbennettcw February 20, 2024 23:26
@mhagel mhagel requested a review from Miaplacidus February 28, 2024 22:08
Copy link
Contributor

@lzach83 lzach83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhagel mhagel merged commit 39cdb84 into master Feb 29, 2024
6 of 7 checks passed
@mhagel mhagel deleted the mark/6635-md branch February 29, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmos Proposals UI: Update Input to be Markdown Editor
3 participants