Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email call callback #6808

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix email call callback #6808

merged 1 commit into from
Feb 20, 2024

Conversation

mzparacha
Copy link
Contributor

Link to Issue

Closes: #6806

Description of Changes

  • Fixes the onEmailLogin login call in old login modal.

"How We Fixed It"

The onEmailLogin callback will not receive HTML synthetic events which were breaking login

Test Plan

  • Login with any email
  • Verify it works

Deployment Plan

N/A

Other Considerations

N/A

@github-actions github-actions bot marked this pull request as draft February 20, 2024 18:27
@mzparacha mzparacha marked this pull request as ready for review February 20, 2024 18:27
@jnaviask
Copy link
Collaborator

Going into v1.0.

Copy link
Contributor

@kurtisassad kurtisassad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@jnaviask jnaviask merged commit 2e630cf into master Feb 20, 2024
7 of 8 checks passed
@jnaviask jnaviask deleted the malik.6806.fix-email-login branch February 20, 2024 18:35
jnaviask pushed a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Sign in with another email address" does not work
3 participants