Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sign-in request branch case for mobile devices when signing in with mobile wallets #6704

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Fix sign-in request branch case for mobile devices when signing in with mobile wallets #6704

merged 2 commits into from
Feb 12, 2024

Conversation

mzparacha
Copy link
Contributor

@mzparacha mzparacha commented Feb 12, 2024 •
edited
Loading

Link to Issue

Closes: #6703

Description of Changes

  • Fixes mobile wallet login signature verification in mobile devices.

"How We Fixed It"

N/A

Test Plan

  • Enable FLAG_NEW_SIGN_IN_MODAL in .env
  • On mobile install a wallet (ex: metamask)
  • Visit the app on local network/ip (ex: IP of your host machine where app is running + port, and use it on a mobile device on which you are testing, -> 192.168.1.2:8080)
  • Try to login with Wallet Connect and chose Metamask from the wallets list, verify that login works as follows
login.mp4

Deployment Plan

N/A

Other Considerations

Should go in with mobile sign-in revamp.

@mzparacha mzparacha self-assigned this Feb 12, 2024
@mzparacha mzparacha marked this pull request as ready for review February 12, 2024 16:38
masvelio
masvelio approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 thanks for fixing this!

mhagel
mhagel approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@mhagel mhagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. tested

@mzparacha mzparacha merged commit c05f6e9 into master Feb 12, 2024
6 of 7 checks passed
@mzparacha mzparacha deleted the malik.6703.fix-signature-request-stage-on-mobile branch February 12, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masvelio masvelio masvelio approved these changes

@mhagel mhagel mhagel approved these changes

@Miaplacidus Miaplacidus Awaiting requested review from Miaplacidus

@lzach83 lzach83 Awaiting requested review from lzach83

@jnaviask jnaviask Awaiting requested review from jnaviask

Assignees

@mzparacha mzparacha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix sign request stage for walletconnect on mobile wallets
3 participants
@mzparacha @mhagel @masvelio