Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up linter scripts and docs #6457

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Conversation

gdjohnson
Copy link
Contributor

In the course of other work, I discovered that the lint-all script alias had been incorrectly documented in Package-Scripts.md. In the course of correcting the documentation, several other clean-up TODOs concerning linter scripts were addressed.

Link to Issue

Links to, but keeps open, #4800.

Description of Changes

  • Corrects lint-all documentation
  • Removes flagged lint script and alias, which is (1) redundant given lint-branch (2) never used in our CI, and not recommended in our maing Linting.md entry

@gdjohnson gdjohnson added the documentation Improvements or additions to documentation label Jan 25, 2024
@gdjohnson gdjohnson requested a review from timolegros January 30, 2024 15:27
Copy link
Collaborator

@timolegros timolegros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is lint-branch.sh deleted (causing error in CI)?

jnaviask
jnaviask previously approved these changes Feb 7, 2024
@jnaviask jnaviask self-requested a review February 7, 2024 19:37
@jnaviask jnaviask dismissed their stale review February 7, 2024 19:37

see tim's comment

@gdjohnson
Copy link
Contributor Author

gdjohnson commented Feb 8, 2024

@jnaviask @timolegros Woops—lint-new-work.sh was the unused script, seems I got mixed up. Very sloppy of me, apologies!

@jnaviask jnaviask merged commit fedae9e into master Feb 9, 2024
6 of 7 checks passed
@jnaviask jnaviask deleted the 4800.graham.linter-description branch February 9, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants