Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors output middleware #10436

Merged
merged 8 commits into from
Jan 6, 2025
Merged

Refactors output middleware #10436

merged 8 commits into from
Jan 6, 2025

Conversation

Rotorsoft
Copy link
Contributor

Link to Issue

Closes: #10430

Description of Changes

  • Creates new generic OutputMiddleware types
  • Refactors all existing middleware to new types
  • Moves signIn step to middleware
  • Adds more tracing to monitor output middleware

"How We Fixed It"

Test Plan

  • Unit tested
  • More manual tests to verify signin flows

Deployment Plan

Other Considerations

@Rotorsoft Rotorsoft merged commit 1d2648a into master Jan 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbennettcw rbennettcw rbennettcw approved these changes

@kurtisassad kurtisassad kurtisassad approved these changes

@timolegros timolegros Awaiting requested review from timolegros

@raykyri raykyri Awaiting requested review from raykyri

@dillchen dillchen Awaiting requested review from dillchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize tRPC output middleware
3 participants
@Rotorsoft @kurtisassad @rbennettcw