-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magic wallet prompt only shows when using magic #10390
Merged
Israellund
merged 7 commits into
master
from
israel.10374.showing-magic-wallet-correctly
Jan 9, 2025
Merged
magic wallet prompt only shows when using magic #10390
Israellund
merged 7 commits into
master
from
israel.10374.showing-magic-wallet-correctly
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masvelio
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not fan of this solution of setting local state. This should be either custom hook that returns boolean or we could add it to the userStore as a computed property
eg
// ... existing imports ...
import { WalletId } from '@hicommonwealth/core'; // Add this import
type CommonProps = {
// ... existing properties ...
hasMagicWallet: boolean; // Add this computed property
};
export const userStore = createStore<UserStoreProps>()(
devtools((set, get) => ({
// ... existing default values ...
hasMagicWallet: false,
setData: (data) => {
if (Object.keys(data).length > 0) {
set((state) => {
const newState = { ...state, ...data };
// Compute hasMagicWallet whenever addresses or activeAccount changes
const currentAddressInfo = newState.addresses?.find(
(addr) => addr.address === newState.activeAccount?.address,
);
const hasMagicWallet = currentAddressInfo?.walletId === WalletId.Magic;
return {
...newState,
hasMagicWallet,
};
});
}
},
})),
);
or selector
export const selectHasMagicWallet = (state: CommonProps) => {
const currentAddressInfo = state.addresses?.find(
(addr) => addr.address === state.activeAccount?.address,
);
return currentAddressInfo?.walletId === WalletId.Magic;
};
const hasMagic = useUserStore(selectHasMagicWallet);
This is a much cleaner implementation, thanks for catching that. Just pushed the changes |
masvelio
reviewed
Jan 6, 2025
...lient/scripts/views/modals/ManageCommunityStakeModal/StakeExchangeForm/StakeExchangeForm.tsx
Outdated
Show resolved
Hide resolved
masvelio
approved these changes
Jan 6, 2025
mzparacha
reviewed
Jan 7, 2025
mzparacha
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #10374
Description of Changes
Test Plan