Improving sidebar navigation on an unscoped page #10199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into salman/Issue#7987/improving-sidebar-navigation
salman-neslit
requested review from
Israellund and
mzparacha
and removed request for
Israellund
|
Noticed a few issues
Screen.Recording.2024-12-16.at.7.56.15.PM.movScreen.Recording.2024-12-16.at.8.00.45.PM.mov
|
mzparacha
reviewed
Dec 16, 2024
| }), | ||
| ); | ||
| setAddresses( | ||
| // @ts-expect-error <StrictNullChecks/> |
There was a problem hiding this comment.
plz try to avoid // @ts-expect-error <StrictNullChecks/> whenever possible
masvelio
reviewed
Dec 20, 2024
| const { openMagicWallet } = useAuthentication({}); | ||
|
|
||
| return ( | ||
| <div className="AddressItem"> |
There was a problem hiding this comment.
you should use existing components like CWIdentificationTag or CWTag.
Take a look on TagsShowcase component for a clue.
| {formatAddressShort(address, 6)} | ||
| </CWText> | ||
| </div> | ||
| {isSelected && <CWIcon iconName="checkCircleFilled" />} |
There was a problem hiding this comment.
desgin vs current, adjust size and coolor of icon
… into salman/Issue#7987/improving-sidebar-navigation
|
Just retested, and i only got 2 and 5 from #10199 (comment) working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #7987
Description of Changes
"How We Fixed It"
Test Plan
Deployment Plan
Other Considerations