Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Permissions Selection UI + Add UPDATE_POLL #10128

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

salman-neslit
Copy link
Collaborator

@salman-neslit salman-neslit commented Dec 4, 2024

Link to Issue

Closes: #10009

Description of Changes

  • Redesigned the Topic Permissions UI to allow:
    • Custom combinations of permissions.
    • Scalable additions for new permissions.
  • Added Voting on Polls (UPDATE_POLL) as a new permission option.

"How We Fixed It"

Test Plan

  • Navigate to community page.
  • Click on "Members & Groups" on the Side Bar.
  • Click on "Create Group".
  • Navigate to Gated Topics Section.
  • Add multiple topics and topic permission then Save.
  • Verify that the permission are applied to the group of the respective topics.
  • Also verify the edit group behaviour by repeating the above steps.

Deployment Plan

Other Considerations

@salman-neslit salman-neslit marked this pull request as ready for review December 5, 2024 09:36
@salman-neslit
Copy link
Collaborator Author

@Israellund @masvelio @mzparacha Can please have a look at this pr.

@mzparacha
Copy link
Contributor

mzparacha commented Dec 16, 2024

Noticed a few issues

  1. Option selection, doesn't look good on mobile
image
  1. Permissions mapping in the create group card is incorrect. I.e these are the permissions I set
image

vs the one that it displays in groups section

image
  1. If a user doesn't have permission to interact with a topic, they should be shown that action (create comment/upvote/poll/thread) with a disabled tooltip, instead of the erroring on submit. Plz see the usage of convertGranularPermissionsToAccumulatedPermissions and where it leads to debug this. The disabled tooltip should now also be shown on the poll voting options, if user doesn't fulfill the gated group criteria.
Screen.Recording.2024-12-16.at.8.22.25.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Permissions Selection UI + Add UPDATE_POLL (allow voting on polls) Permission
3 participants