Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support global-error.js #596

Merged
merged 13 commits into from
Aug 4, 2024
Merged

feat: support global-error.js #596

merged 13 commits into from
Aug 4, 2024

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Aug 3, 2024

I don't think this has any effect on ssr, so we can probably just directly import it on browser entry only via virtual module.

todo

  • tweak style
  • test

references

Copy link
Owner Author

hi-ogawa commented Aug 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on Graphite Graphite

@hi-ogawa hi-ogawa marked this pull request as ready for review August 4, 2024 04:18
Copy link
Owner Author

hi-ogawa commented Aug 4, 2024

Merge activity

@hi-ogawa hi-ogawa merged commit 40aa862 into main Aug 4, 2024
9 checks passed
@hi-ogawa hi-ogawa deleted the feat-global-error branch August 4, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant