Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignoreExportAllDeclaration during client/server transform #579

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Jul 18, 2024

It looks like we'll need this for material ui

Probably Next.js happens to support this since mui is a broken esm package. Not sure what to do, so just loosen the check, add a test and call it a day.

todo

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on Graphite Graphite

Copy link

pkg-pr-new bot commented Jul 18, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 653af39

@hiogawa/react-server

npm i https://pkg.pr.new/hi-ogawa/vite-plugins/@hiogawa/react-server@579

@hiogawa/react-server-next

npm i https://pkg.pr.new/hi-ogawa/vite-plugins/@hiogawa/react-server-next@579

@hiogawa/transforms

npm i https://pkg.pr.new/hi-ogawa/vite-plugins/@hiogawa/transforms@579

@hiogawa/vite-plugin-ssr-middleware

npm i https://pkg.pr.new/hi-ogawa/vite-plugins/@hiogawa/vite-plugin-ssr-middleware@579


templates

@hi-ogawa hi-ogawa changed the title fix: ignoreExportAllDeclaration during client/server transform fix: ignoreExportAllDeclaration during client/server transform Jul 18, 2024
hi-ogawa added a commit to hi-ogawa/material-ui that referenced this pull request Jul 18, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review July 18, 2024 10:01
@hi-ogawa hi-ogawa force-pushed the fix-ignoreExportAllDeclaration branch from 1a603fb to e37cacb Compare July 19, 2024 01:09
@hi-ogawa hi-ogawa merged commit 498a63c into main Jul 19, 2024
9 checks passed
@hi-ogawa hi-ogawa deleted the fix-ignoreExportAllDeclaration branch July 19, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant