Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: skip redundant flight render on action redirect #530

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Jul 9, 2024

It seems like special-casing action redirect handling is required sooner or later. This seems like a nice simplification and for eample, this should already help this issue explained in the TODO here https://github.com/hi-ogawa/rsc-on-vite/blob/89303058e0b46799da581b42fdf5797aa52faa8a/remix-tutorial/src/routes/_action.ts#L13-L18

We might eventually need to actually include the entire flight data to reduce redirect round trip though.


I thought RedirectBoundary is not necessary anymore, but that's not the case since we still need to handle redirect throw from server component tree.

Copy link
Owner Author

hi-ogawa commented Jul 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on Graphite Graphite

@hi-ogawa hi-ogawa changed the title refactor: simplify action redirect handling refactor: skip redundant flight render on action redirect Jul 9, 2024
@hi-ogawa hi-ogawa mentioned this pull request Jul 9, 2024
4 tasks
@hi-ogawa hi-ogawa marked this pull request as ready for review July 9, 2024 22:54
Copy link
Owner Author

hi-ogawa commented Jul 9, 2024

Merge activity

@hi-ogawa hi-ogawa merged commit 0b6df98 into main Jul 9, 2024
6 checks passed
@hi-ogawa hi-ogawa deleted the refactor-action-redirect-js branch July 9, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant