Add "A Healthy Slice of Life" site #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm using jj instead of Git and that appears to break the |
bcspragu
added a commit
to bcspragu/plainoldrecipe
that referenced
this pull request
Dec 1, 2024
Previously called `wild_mode`, this will attempt to pull the recipe schema from sites that aren't explicitly hardcoded, works for lots of site. As an example, [this recipe](https://www.ahealthysliceoflife.com/red-lentil-carrot-curry-recipe/) previously failed, but succeeds with `supported_only=False` (though I'm adding that site explicitly [here](hhursev/recipe-scrapers#1413))
bcspragu
added a commit
to bcspragu/plainoldrecipe
that referenced
this pull request
Dec 1, 2024
Previously called `wild_mode`, this will attempt to pull the recipe schema from sites that aren't explicitly hardcoded, works for lots of site. As an example, [this recipe](https://www.ahealthysliceoflife.com/red-lentil-carrot-curry-recipe/) previously failed, but succeeds (with minor errors on the ingredients) with `supported_only=False` (though I'm adding that site explicitly [here](hhursev/recipe-scrapers#1413)). I think that's an improvement over nothing, but would be willing to add some messaging to indicate "this site is only kinda supported"
jknndy
requested changes
Dec 1, 2024
`black ./recipe_scrapers/ahealthysliceoflife.py`
`python ./scripts/reorder_json_keys.py`
|
Thanks for the pointers, everything should be addressed! |
jknndy
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1412