Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make retry cover errors during headers and during body #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mitom
Copy link

@mitom mitom commented Jan 28, 2024

I believe this fixes one part of the issue in #115 and maybe helps #113 a bit as well, not sure if it entirely closes either but maybe one step closer.

The logic behind it is fairly simple - make the error handling during parsing the resposne be the same as the error handling of the http event listeners, the __onError function already takes care of setting the state to failed when we're out of retries and also emitting the error.

@mitom
Copy link
Author

mitom commented Jan 29, 2024

Actually it looks like this is not ready to merge, the retry counter doesn't seem to be increasing so it goes infinitely.

@hgouveia
Copy link
Owner

Actually it looks like this is not ready to merge, the retry counter doesn't seem to be increasing so it goes infinitely.

ok ok, i will check all these when i have some time including #115 and #113 , but unfortunately i am still unable to do a proper check and fix it, i will let you know as soon is possible

@mitom
Copy link
Author

mitom commented Jan 29, 2024

Thank you, and no worries - I'm trying to help as much as I can, not trying to rush you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants