fix: not stringifying data if data logging is disabled (#114)

Fixes #102
hg-pyun · Dec 13, 2022 · d756595 · d756595
1 parent 1428255
commit d756595
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/common/__test__/string-builder.spec.js b/src/common/__test__/string-builder.spec.js
@@ -71,3 +71,17 @@ test('makeStatus should add status', () => {
 
     expect(result).toContain('200:OK');
 });
+
+test('makeData should not stringify data if configured not to', () => {
+    const config = {
+        ...getGlobalConfig(),
+        data: false,
+    };
+    const a = {};
+    const b = {};
+    a.b = b;
+    b.a = a;
+    const sb = new StringBuilder(config);
+    const result = sb.makeData(a).build();
+    expect(result).toEqual('');
+});
diff --git a/src/common/string-builder.ts b/src/common/string-builder.ts
@@ -62,8 +62,10 @@ class StringBuilder {
     }
 
     makeData(data: object) {
-        const str = typeof data === `string` ? data : JSON.stringify(data);
-        if(this.config.data && data) this.printQueue.push(str);
+        if(this.config.data && data) {
+            const str = typeof data === `string` ? data : JSON.stringify(data);
+            this.printQueue.push(str);
+        }
         return this;
     }