Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): replace jest with vitest #71

Merged
merged 5 commits into from
Mar 20, 2024
Merged

chore(deps): replace jest with vitest #71

merged 5 commits into from
Mar 20, 2024

Conversation

jordanshatford
Copy link
Collaborator

Let me know if there are any concerns with this. E2E and Unit tests will not be able to be split (although all E2E tests are ignored right now). We can likely re-write the e2e tests with something like playright.

@mrlubos
Copy link
Member

mrlubos commented Mar 18, 2024

I don't want to do this just yet! Yes we need to fix e2e, and yes they should run in CI. Right now, I run them at leat locally sometimes, but I wouldn't want them to be coupled with unit tests as it would slow down normal development

@jordanshatford
Copy link
Collaborator Author

I don't want to do this just yet! Yes we need to fix e2e, and yes they should run in CI. Right now, I run them at leat locally sometimes, but I wouldn't want them to be coupled with unit tests as it would slow down normal development

I agree with that. This PR can be left for awhile and I will work on implementing the e2e tests better. We can look at it again once I get some more work done on it.

@mrlubos
Copy link
Member

mrlubos commented Mar 18, 2024

@jordanshatford no rush on this. I'd like to arrive at a good architecture for our tests first before switching the whole tooling, that's a way bigger problem. Are Angular e2e tests working for you?

@jordanshatford
Copy link
Collaborator Author

@jordanshatford no rush on this. I'd like to arrive at a good architecture for our tests first before switching the whole tooling, that's a way bigger problem. Are Angular e2e tests working for you?

They are not

@mrlubos mrlubos self-assigned this Mar 19, 2024
Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@mrlubos mrlubos merged commit fc3ea9a into hey-api:master Mar 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants